Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 37 model counts4stable models #38

Merged
merged 6 commits into from
Mar 23, 2022

Conversation

ellmau
Copy link
Owner

@ellmau ellmau commented Mar 22, 2022

What does this PR do?

Implements #37

Checklist before creating a non-draft PR

  • All tests are passing
  • Clippy has no complains
  • Code is rustfmt formatted
  • Applicable labels are chosen (Note: it is not necessary to replicate the labels from the related issues)
  • There are no other open Pull Requests for the same update/change.
    • If there is a good reason to have another PR for the same update/change, it is well justified.

Checklist on Guidelines and Conventions

  • Commit messages follow our guidelines
  • Code is self-reviewed
  • Naming conventions are met
  • New features are tested
    • quickcheck has been considered
    • All variants are considered and checked
  • Clippy Compiler-exceptions
    • Used in a sparse manner
    • If used, a separate comment describes and justifies its use
  • rustdoc comments are self-reviewed and descriptive
  • Error handling
    • Use of panic!(...) applications is justified on non-recoverable situations
    • expect(...) is used over unwrap() (except obvious test-cases)
  • No unsafe code (exceptions need to be discussed specifically)

@ellmau ellmau added enhancement New feature or request library This issue or pull request is related to the library labels Mar 22, 2022
@ellmau ellmau added this to the Release on crates.io milestone Mar 22, 2022
@ellmau ellmau self-assigned this Mar 22, 2022
@ellmau ellmau marked this pull request as ready for review March 22, 2022 17:28
@ellmau
Copy link
Owner Author

ellmau commented Mar 22, 2022

Resolves #37

@ellmau ellmau linked an issue Mar 22, 2022 that may be closed by this pull request
ellmau added 2 commits March 23, 2022 12:53
Fixed a bug, where the updates have not been done correctly
Added debug/trace messages
Note: reduced timeouts to "only" 160
@ellmau ellmau added the binary This issue or pull request is related to the binary label Mar 23, 2022
@ellmau
Copy link
Owner Author

ellmau commented Mar 23, 2022

As mentioned in commit a974ad8, this approach seems to be more efficient than the previous ones (i.e. only 160 timeouts, which is far less then the ~260 ones beforehand)

@ellmau ellmau merged commit 3c8cbd8 into main Mar 23, 2022
@ellmau ellmau deleted the feature/issue_37_model-counts4stable-models branch April 8, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binary This issue or pull request is related to the binary enhancement New feature or request library This issue or pull request is related to the library
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Utilise (counter-)model counts for stable models
1 participant