Reactor viewport initial scale #1911
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elm reactor does not set viewport meta attribute which makes it hard to develop pages for mobile devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the issues then I was developing mobile optimized pages, since the viewport meta attribute was not set for elm reactor generated page. I think this change is not yet complete, b/c we either need to mobile optimize all the reactor generated pages, or set this attribute in the pages that have compiled Elm code.
Let me know if this change makes sense, and do we need to mobile optimize all pages. I didn't want to fully implement this feature, without consulting it before.