Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
terser does not require two passes. I tried out running the
--compress
and--mangle
passes separately, but running one pass with--compress --mange
yields the exact same byte count (just as it should be). (uglifyjs, even in the current version 3.8.0, still requires two passes.)The compression is very close to uglifyjs. uglifyjs takes a 691.340 bytes
elm.js
to 147.094 bytes, while terser yields 149.607 bytes.The reason I tried out terser was that uglifyjs does not handle modern JavaScript (newer than ES5), which lead to an issue in elm-pages. Terser does, is nicely documented, and easily replaces uglifyjs.
Supporting modern JS is not really relevant here right now, since the Elm compiler outputs ES5. But that terser only requires one pass makes explaining it easier.