Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation deadEndsToString #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YuichiMorita
Copy link

simple implementation deadEndsToString function

simple implementation deadEndsToString function
@brianvanburken
Copy link

This is a duplicate of #16

@bburdette
Copy link

I like this version, with the row and col position. Nice!

@evancz
Copy link
Member

evancz commented Dec 9, 2019

@brianvanburken, it is desirable to have multiple issues or PRs about a topic.

  • With issues, having more examples makes it easier to figure out. Having many examples in a single thread makes it very mentally difficult to disentangle when there are three or four different root, so "duplicates" is actually way nicer to work with in my experience! This is also a good way to gauge "how often is this discovered independently?" and does not put an unreasonable burden on reporters to be super informed about everything going on in other issues.
  • With PRs, you get similar benefits. Seeing different perspectives on how to fix something only helps!

Point is, I like to have "duplicates" on my projects! I hope this doesn't sound like a reprimand. I just need to tell people about this because it is not the norm!

@evancz evancz reopened this Dec 9, 2019
@joshuakb2
Copy link

Hey @evancz, are you reviewing this pull request? I just tried using this feature and got "TODO deadEndsToString". Even a simple implementation like this one would be a huge improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants