Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rendering issues with overlapping layers #30

Closed
ghost opened this issue Sep 30, 2018 · 5 comments
Closed

rendering issues with overlapping layers #30

ghost opened this issue Sep 30, 2018 · 5 comments
Labels

Comments

@ghost
Copy link

ghost commented Sep 30, 2018

I'm using the Unity PPS bloom and any time the effect overlaps with another object it creates really bad colour distortions and bloom size changes, sometimes blotting out the entire screen. any idea if I just have this set up wrong or what might be causing that? Thanks!

https://i.imgur.com/bL1DQ2i.png
https://i.imgur.com/zcjquYQ.png

@elringus
Copy link
Owner

On the first screenshot I can't really see any issues. The middle character has a weird outline, but looks like the outline color is set to black? Bloom won't work properly with blacks, I guess.

Regarding bloom size changes: depending on the material, when HDR colors overlap, it could brighten the bloom effect. It doesn't really have anything to do with the SpriteGlow, but rather with the chosen bloom effect implementation.

@ghost
Copy link
Author

ghost commented Sep 30, 2018

Thanks for the quick response! Yeah I suppose it's kinda hard to tell what's going on in a still image. The sprites on the left actually have a white outline.

Here's what I mean in a short video using your demo scene:
https://gfycat.com/SeparatePettyAmericanratsnake

@elringus
Copy link
Owner

Oh, now that's look interesting! I'll make sure to check this out, thanks for letting me know :)

elringus added a commit that referenced this issue Oct 1, 2018
@elringus
Copy link
Owner

elringus commented Oct 1, 2018

The issue is now fixed in the latest release: https://github.com/Elringus/SpriteGlow/releases/tag/v1.6-release

@ghost
Copy link
Author

ghost commented Oct 1, 2018

Awesome, that did the trick! Thanks!

@ghost ghost closed this as completed Oct 1, 2018
@elringus elringus added the bug label Oct 29, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant