Bump Bowtie to 2.4.4 #127
Merged
Bump Bowtie to 2.4.4 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for restricting the version to 2.3.5.1 was that the tool would create incorrect VN tags in the SAM header, see #51. This bug has since been fixed according to bioconda/bioconda-recipes#22836 . The upstream issue at BenLangmead/bowtie2#301 was re-opened, though. Closes #121
|
R 4.0 Should be fine. I realised that Picard does use R as well so it was an implicit dependency in the environment already so maybe that's where the conflict was. |
|
Let’s merge it then. Thanks for the pointer to the Picard/R issue, that was an interesting read. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for restricting the version to 2.3.5.1 was that the tool would
create incorrect VN tags in the SAM header, see #51. This bug has since
been fixed according to
bioconda/bioconda-recipes#22836 .
(The upstream issue at BenLangmead/bowtie2#301 was re-opened, though.)
I had to reduce R to 4.0 because otherwise there were version conflicts.
Closes #121