Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Investigate alternative to outputting __insertStyle function into './dist/node_modules/...' #158

Closed
1 task done
elycruz opened this issue Sep 10, 2024 · 0 comments · Fixed by #161
Closed
1 task done
Assignees
Labels
docs Documentation issue.

Comments

@elycruz
Copy link
Owner

elycruz commented Sep 10, 2024

Third party library projects, by default, configure 'node_modules' to be ignored (either by way of a 'tsconfig.*', and/or a build file (rollup.config, etc.)). This makes it unclear how to use the insert feature to inject css into bundles when the generated function module, itself, is ignored (due to node_modules/ usually being ignored (as a practice) in user-land projects).

Acceptance Criteria

We need to:

  • Document the approach for using our plugin's insert feature from webpack/rollup/etc., projects - Specifically we need to make sure users understand how to include the generated './dist/node_modules/...' file/folder, in their builds.
@elycruz elycruz added the docs Documentation issue. label Sep 10, 2024
@elycruz elycruz self-assigned this Sep 10, 2024
elycruz added a commit that referenced this issue Sep 24, 2024
- Notes on using 'insert' in different
  scenarios.
@elycruz elycruz linked a pull request Sep 24, 2024 that will close this issue
elycruz added a commit that referenced this issue Sep 24, 2024
…dules_export_docs

feat: issue-#158 - insert feat docs
elycruz added a commit that referenced this issue Sep 24, 2024
- Simplified the usage notice
  and added link to 'package.json.files'
  docs.
elycruz added a commit that referenced this issue Sep 25, 2024
- Simplified the usage notice
  and added link to 'package.json.files'
  docs.
elycruz added a commit that referenced this issue Oct 18, 2024
elycruz added a commit that referenced this issue Oct 30, 2024
…dules_export_docs

Issue #158   insertstyle node modules export docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant