chore: move npm test to pre-push hook #148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While rebasing #143 I noticed that now tests are run each time a
commit
is performed.Someone (me 😅) could using commits as a backup of a work in progress. E.g.:
--amend
push
In the current situation I would find myself unable to commit because some tests might be failing.
To be able to commit I have to add
--no-verify
flag to thecommit
command, which IMHO is not ideal.This PR basically move the
npm test
frompre-commit
topre-push
hook.I think is better to check that tests are working before push instead of every commit.