Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move npm test to pre-push hook #148

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

marcalexiei
Copy link
Collaborator

While rebasing #143 I noticed that now tests are run each time a commit is performed.

Someone (me 😅) could using commits as a backup of a work in progress. E.g.:

  • make an incremental commit using --amend
  • making a certain amount of commits and squash them together before push

In the current situation I would find myself unable to commit because some tests might be failing.
To be able to commit I have to add --no-verify flag to the commit command, which IMHO is not ideal.


This PR basically move the npm test from pre-commit to pre-push hook.
I think is better to check that tests are working before push instead of every commit.

@marcalexiei marcalexiei changed the title chore: move npm test to pre-push commit chore: move npm test to pre-push hook Jul 6, 2024
Copy link
Owner

@elycruz elycruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@elycruz elycruz merged commit 0425739 into elycruz:main Jul 13, 2024
3 checks passed
@marcalexiei marcalexiei deleted the feature/git-hooks branch August 7, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants