Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore + refactor: add eslint #179

Merged
merged 2 commits into from
Jan 10, 2025
Merged

chore + refactor: add eslint #179

merged 2 commits into from
Jan 10, 2025

Conversation

marcalexiei
Copy link
Collaborator

Last task of #141

Add eslint to the project:

  • typescript-eslint setup has been used
  • added also eslint-plugin-ava to check test files
  • CI workflow now run lint script

Additionally generateBundle has been converted to an async function to improve his readability

@marcalexiei marcalexiei mentioned this pull request Jan 7, 2025
Closed
7 tasks
@marcalexiei marcalexiei marked this pull request as ready for review January 7, 2025 01:47
@marcalexiei marcalexiei requested a review from elycruz as a code owner January 7, 2025 01:47
elycruz
elycruz approved these changes Jan 10, 2025
View reviewed changes
Copy link
Owner

@elycruz elycruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@elycruz elycruz merged commit 6712bd2 into elycruz:main Jan 10, 2025
9 checks passed
@marcalexiei marcalexiei deleted the eslint branch January 13, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elycruz elycruz elycruz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcalexiei @elycruz