-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate numeric fields in submit file dialog #2383
Validate numeric fields in submit file dialog #2383
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested locally but the code LGTM. Thanks!
Fixes #1516
The file submit dialog only validates fields marked as required.
This PR adds a validator for non-required numeric fields in the UI.
What changes were proposed in this pull request?
Added validation for numeric fields in submit file dialog. If the input is negative, disable the OK button

Also added descriptions to those resources fields to be consistent with pipeline node properties display.
How was this pull request tested?
Manual testing for invalid input from the keyboard, invalid input using the up/down arrows in the UI.
Checked pipeline run/submit dialog validation haven't changed.
Developer's Certificate of Origin 1.1