Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate numeric fields in submit file dialog #2383

Merged

Conversation

karlaspuldaro
Copy link
Member

@karlaspuldaro karlaspuldaro commented Jan 11, 2022

Fixes #1516
The file submit dialog only validates fields marked as required.
This PR adds a validator for non-required numeric fields in the UI.

What changes were proposed in this pull request?

Added validation for numeric fields in submit file dialog. If the input is negative, disable the OK button
image

Also added descriptions to those resources fields to be consistent with pipeline node properties display.

How was this pull request tested?

Manual testing for invalid input from the keyboard, invalid input using the up/down arrows in the UI.
Checked pipeline run/submit dialog validation haven't changed.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Jan 11, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@karlaspuldaro karlaspuldaro added this to the 3.5.0 milestone Jan 11, 2022
Copy link
Member

@akchinSTC akchinSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good to me.

Copy link
Member

@lresende lresende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above.

@ptitzler ptitzler modified the milestones: 3.5.0, 3.6.0 Jan 20, 2022
Copy link
Member

@marthacryan marthacryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested locally but the code LGTM. Thanks!

@akchinSTC akchinSTC merged commit 6b03bd8 into elyra-ai:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submit notebook/script dialog validation can be improved
5 participants