-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Airflow provider package catalog connector #2438
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
This PR is a redo of #2416, which had issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good and working well for me! Just one NIT below
...ine/airflow/provider_package_catalog_connector/airflow_provider_package_catalog_connector.py
Outdated
Show resolved
Hide resolved
elyra/pipeline/airflow/provider_package_catalog_connector/airflow-provider-package-catalog.json
Outdated
Show resolved
Hide resolved
elyra/pipeline/airflow/provider_package_catalog_connector/airflow-provider-package-catalog.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds a catalog connector for Apache Airflow provider packages. Connector instances require the user to configure a download URL for the Apache Airflow provider package that is installed in the cluster.
Requires #2418,
#2409, #2437What changes were proposed in this pull request?
catalog-connectors
directory to the repository root, containing in theairflow
subdirectory the newly introduced connectorMakefile
to include newlint-connectors
target, which was also added as a dependency to thelint
tasklint-connectors
task to Github'sbuild.yaml
Notes:
apache_airflow_providers_ssh
- see later comment) and Python file name (e.g.airflow/providers/ssh/operators/ssh.py
) as hash keys, which are used to internally identify operators in the palette.2.3.0-py3-none-any
, is currently not part of the key to avoid potential versioning issues. For example, assume user A adds operators from archive...2.3.0-py3-none-any
to the Elyra deployment and creates a pipeline using some of the operators. User B adds operators from an older archive, such as...2.2.0-py3-none-any
. If we were to include the archive name as is as a key, user B would not be able to run pipelines that user A created (and vice versa) because (pseudo code)How was this pull request tested?
Error scenario testing:
Unit testing included the providers listed in this discussion thread
Notes:
There are unresolved Elyra Airflow component parser issues that need to be addressed before the Airflow 1.10.15 package can be used.Improve Airflow parser functionality #2418Developer's Certificate of Origin 1.1