-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for rjsf in pipeline properties #2780
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Thank you! Looking good. It appears to preserve default values, which I would expect to happen since the user didn't provide a property value. |
Corresponds to elyra-ai/elyra#2780 Co-authored-by: Alex Bozarth <ajbozart@us.ibm.com>
Congratulations (and thank you ❤️) to everyone that worked on this - it's one for the ages! 🎉 |
I would also love to thank everyone for their amazing effort!!! ❤️ |
Corresponding to elyra-ai/pipeline-editor#197.
Fixes #2759
Todo:
Testing Follow Up TODOs:
component_parameters
stanza) when connected 2 nodes (no longer seeing; uncheck if not the case)app_data.properties.pipeline_defaults
stanzacomponent_parameters
stanzasvalidation.py:493-500
) after this change is madeinputpath
structure in pipeline JSON needs fixed[ ] user-friendly key-value inputs (env variables etc all)- pushing to next releasecomponent_source
parameter should be moved out ofcomponent_parameters
stanza of pipeline JSON (some frontend work required in order to still display the property in properties panel)Developer's Certificate of Origin 1.1