-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix release script and instructions #2843
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
bbaf977
to
d4d1d4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Just had the one comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you.
check_run(["git", "checkout", f"tags/v{config.new_version}"], cwd=config.source_dir, capture_output=False) | ||
check_run(["make", "container-images"], cwd=config.source_dir, capture_output=False) | ||
check_run(["git", "checkout", "main"], cwd=config.source_dir, capture_output=False) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the checkouts are handled before this, on the main driver...
you just need to build the images here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think up to this point, the current branch of the repository under build/release/elyra
would be set to main
still. So any image built without these checkouts would be built using the dev
tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lresende - if youre good with this im going to merge
e9838f6
to
04e4ae9
Compare
Closes #2840
What changes were proposed in this pull request?
Makefile
to properly detect whether the local source code is associated with an official releaseHow was this pull request tested?
make publish-container-images
using a customizedMakefile
versionmake docs
Developer's Certificate of Origin 1.1