Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release script and instructions #2843

Merged
merged 5 commits into from
Aug 15, 2022

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Jul 19, 2022

Closes #2840

What changes were proposed in this pull request?

  • Update Makefile to properly detect whether the local source code is associated with an official release
  • Update release documentation (remove obsolete instructions and apply minor cosmetic changes)
  • The release script will now build and publish the release images during the release process as a single step

How was this pull request tested?

  • Ran make publish-container-images using a customized Makefile version
  • Reviewed output of make docs

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ptitzler ptitzler added kind:bug Something isn't working component:build build and build related issues(dependencies and docker) labels Jul 19, 2022
@elyra-bot
Copy link

elyra-bot bot commented Jul 19, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler ptitzler added this to the 3.11.0 milestone Jul 19, 2022
@ptitzler ptitzler added the area:documentation Improvements or additions to documentation label Jul 19, 2022
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Just had the one comment.

Makefile Outdated Show resolved Hide resolved
@akchinSTC akchinSTC requested a review from kevin-bates August 12, 2022 15:40
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you.

check_run(["git", "checkout", f"tags/v{config.new_version}"], cwd=config.source_dir, capture_output=False)
check_run(["make", "container-images"], cwd=config.source_dir, capture_output=False)
check_run(["git", "checkout", "main"], cwd=config.source_dir, capture_output=False)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the checkouts are handled before this, on the main driver...
you just need to build the images here

Copy link
Member

@akchinSTC akchinSTC Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think up to this point, the current branch of the repository under build/release/elyra would be set to main still. So any image built without these checkouts would be built using the dev tag

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lresende - if youre good with this im going to merge

@akchinSTC akchinSTC merged commit 1be1817 into elyra-ai:main Aug 15, 2022
@ptitzler ptitzler deleted the fix-release-script branch August 16, 2022 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:documentation Improvements or additions to documentation component:build build and build related issues(dependencies and docker) kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile doesn't properly apply 'latest' tag
4 participants