-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "what's new" tile to launcher #2857
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @salonee13 , code and functionality look great!
I tested locally and I can see the new launcher card:
It would be helpful to also add a small integration test to make sure the card is always visible.
This would be done in this test file and you can use the documentation card test as example. It would look like
cy.get('.jp-LauncherCard[data-category="Elyra"][title="What\'s new"]:visible');
This looks great, thanks for the contribution! One suggestion I have is that I think it'd be better if the icon was more specific to releases.
Let me know if you need any help with that! |
hi, I would like to be assigned to this PR, I would like to add the requested changes |
@salonee13 - can you add @shadowluigi27 to your list of collaborators like we did for cherry? |
Absolutely, I just added him as a collaborator.
…On Mon, Aug 8, 2022 at 11:34 AM Alan Chin ***@***.***> wrote:
@salonee13 <https://github.com/salonee13> - can you add @shadowluigi27
<https://github.com/shadowluigi27> to your list of collaborators like we
did for cherry?
—
Reply to this email directly, view it on GitHub
<#2857 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWSSEBSWXZ7PXOKEOOYRYKDVYESINANCNFSM54XCH7SQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@salonee13 - awesome! thanks! |
Remember to also update the release script as indicated in this comment. As is the link would always open to the 'latest' release, which isn't necessarily the release the user has installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing the review comments! This looks great, I only have a small suggestion to fix on the icon styling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See earlier comments.
Test failure and tooltip issue have been resolved. Thx @karlaspuldaro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #2795
What changes were proposed in this pull request?
Added a tile in launcher called 'What's new'. It is connected to a link that takes you to the releases page and shows you the latest version of Elyra you have installed.
How was this pull request tested?
I ran make watch and then opened another terminal and ran jupyterlab --watch and was able to edit and view the changes to the launcher to check and see if the tile was there and worked by opening the correct link.
Developer's Certificate of Origin 1.1