Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for COS public endpoint to Kubeflow Pipelines runtime config #2887

Merged
merged 6 commits into from
Aug 18, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions elyra/metadata/schemas/kfp.json
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,16 @@
"ui:placeholder": "https://your-cos-service:port"
}
},
"cos_public_endpoint": {
ptitzler marked this conversation as resolved.
Show resolved Hide resolved
"title": "Public Cloud Object Storage Endpoint",
"description": "The public Cloud Object Storage endpoint",
"type": "string",
"format": "uri",
"uihints": {
"category": "Cloud Object Storage",
"ui:placeholder": "https://your-public-cos-endpoint:port"
}
},
"cos_bucket": {
"title": "Cloud Object Storage Bucket Name",
"description": "The Cloud Object Storage bucket name",
Expand Down
3 changes: 2 additions & 1 deletion elyra/pipeline/kfp/processor_kfp.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ def process(self, pipeline):

# unpack Cloud Object Storage configs
cos_endpoint = runtime_configuration.metadata["cos_endpoint"]
cos_public_endpoint = runtime_configuration.metadata.get("cos_public_endpoint", cos_endpoint)
portellaa marked this conversation as resolved.
Show resolved Hide resolved
cos_bucket = runtime_configuration.metadata["cos_bucket"]

# Determine which provider to use to authenticate with Kubeflow
Expand Down Expand Up @@ -362,7 +363,7 @@ def process(self, pipeline):
)

if pipeline.contains_generic_operations():
object_storage_url = f"{cos_endpoint}"
object_storage_url = f"{cos_public_endpoint}"
os_path = join_paths(pipeline.pipeline_parameters.get(COS_OBJECT_PREFIX), pipeline_instance_id)
object_storage_path = f"/{cos_bucket}/{os_path}"
else:
Expand Down