Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for COS public endpoint to Airflow runtime config #2890

Merged
merged 3 commits into from
Aug 19, 2022

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Aug 18, 2022

This PR adds support for an optional public object storage endpoint in the Apache Airflow runtime configuration, similar to what #2887 delivers for Kubeflow Pipelines.

This PR should be merged after #2887 to resolve a conflict in packages/pipeline-editor/src/RuntimesWidget.tsx. The change in this PR must take precedence over the change in the other PR or things will break.

Runtime configuration metadata editor:

image

Runtime configuration list entry (no public endpoint configured)

image

Pipeline submission confirmation message, referencing the regular endpoint

image

Runtime configuration list entry (bogus public endpoint configured)

image

Pipeline submission confirmation message, referencing the public endpoint
image

What changes were proposed in this pull request?

How was this pull request tested?

  • Manual testing:
    • Airflow RTC configured without public COS endpoint
      • tested editor and RTC list view
      • tested run pipeline and export pipeline
    • Airflow RTC configured with public COS endpoint
      • tested editor and RTC list view
      • tested run pipeline and export pipeline
  • Updated existing test, which failed due to new property

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ptitzler ptitzler added kind:enhancement New feature or request component:metadata-editor Metadata Editor Extension platform: pipeline-Airflow Related to usage of Apache Airflow as pipeline runtime labels Aug 18, 2022
@ptitzler ptitzler added this to the 3.11.0 milestone Aug 18, 2022
@elyra-bot
Copy link

elyra-bot bot commented Aug 18, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@akchinSTC akchinSTC self-requested a review August 18, 2022 16:29
@ptitzler ptitzler merged commit 03b4f18 into elyra-ai:main Aug 19, 2022
@ptitzler ptitzler deleted the public-os-endpoint-airflow branch August 19, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:metadata-editor Metadata Editor Extension kind:enhancement New feature or request platform: pipeline-Airflow Related to usage of Apache Airflow as pipeline runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants