Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generic nodes to use static icon api #2908

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Conversation

ajbozarth
Copy link
Member

Currently generic nodes still use encoded strings of the LabIcon svgs.
This PR adds copies of those svgs to the backend static API and
updates the pipeline editor to use those for the persisted values,
like we already do with kfp and airflow nodes.

Fixes #2907

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Currently generic nodes still use encoded strings of the LabIcon svgs.
This PR adds copies of those svgs to the backend static API and
updates the pipeline editor to use those for the persisted values,
like we already do with kfp and airflow nodes.

Fixes elyra-ai#2907
@ajbozarth ajbozarth added this to the 3.11.1 milestone Aug 26, 2022
@ajbozarth ajbozarth self-assigned this Aug 26, 2022
@elyra-bot
Copy link

elyra-bot bot commented Aug 26, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@akchinSTC
Copy link
Member

running front end integration tests to regenerate snapshots are failing, might need to look into it as substask

Copy link
Member

@karlaspuldaro karlaspuldaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Only didn't get a chance to test it locally, although we cover icons in integration tests :)

@akchinSTC akchinSTC merged commit 0c07109 into elyra-ai:main Aug 30, 2022
akchinSTC pushed a commit that referenced this pull request Aug 30, 2022
Currently generic nodes still use encoded strings of the LabIcon svgs.
This PR adds copies of those svgs to the backend static API and
updates the pipeline editor to use those for the persisted values,
like we already do with kfp and airflow nodes.

Fixes #2907
@ajbozarth ajbozarth deleted the icons branch August 30, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to Remove embedded SVG in Pipeline File
3 participants