Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new integration test for testing custom export filename #3052

Merged
merged 3 commits into from
Dec 12, 2022

Conversation

kiersten-stokes
Copy link
Member

Co-authored by @salonee13

Signed-off-by: Kiersten Stokes kierstenstokes@gmail.com

What changes were proposed in this pull request?

PR adds a new integration test to cover functionality introduced by #2999

How was this pull request tested?

CI passing

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
@kiersten-stokes kiersten-stokes added the component:test Test-related label Dec 9, 2022
@kiersten-stokes kiersten-stokes added this to the 3.14.0 milestone Dec 9, 2022
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
@akchinSTC akchinSTC self-requested a review December 12, 2022 16:23
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akchinSTC akchinSTC merged commit dd1f353 into elyra-ai:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:test Test-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants