Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repackage data files into elyra-server distribution #3081

Merged
merged 4 commits into from
Jan 23, 2023

Conversation

akchinSTC
Copy link
Member

@akchinSTC akchinSTC commented Jan 19, 2023

Signed-off-by: Alan Chin akchin@us.ibm.com

Fixes #3079

  • Data files (non py files) were not being packaged for the elyra-server distribution after switching over to the new build format
  • Small changes added to dockerfiles for native compilation.

What changes were proposed in this pull request?

How was this pull request tested?

Test the creation of the package and release script with the following

python create-release.py prepare --version 3.14.2 --dev-version 3.15.0

this builds a 3.14.2 release locally. (nothing is pushed)

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Alan Chin <akchin@us.ibm.com>
@akchinSTC akchinSTC added this to the 3.14.2 milestone Jan 19, 2023
@akchinSTC akchinSTC added the component:build build and build related issues(dependencies and docker) label Jan 19, 2023
@akchinSTC akchinSTC changed the title Repackage metadata schemas in elyra distribution Repackage data files into elyra-server distribution Jan 19, 2023
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alan - thanks for working on this.

It looks like using create-release.py is the only way to build elyra-server. Could you please provide the command(s) necessary to build (and install) this. I'm assuming the build produces a wheel file which is then pip installed, but I suppose it could be different.

Thanks.

pyproject.toml Outdated Show resolved Hide resolved
Signed-off-by: Alan Chin <akchin@us.ibm.com>
@ptitzler ptitzler self-requested a review January 20, 2023 17:37
Signed-off-by: Alan Chin <akchin@us.ibm.com>
Signed-off-by: Alan Chin <akchin@us.ibm.com>
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alan.

@akchinSTC akchinSTC merged commit 48bad71 into elyra-ai:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:build build and build related issues(dependencies and docker)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elyra fails to start if only the pipeline editor extension is installed
3 participants