-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to Python 3.7 #3101
Conversation
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
There's no need to increase the floor as newer versions of Python work fine. That comment was there to prevent its increase so long as Python 3.7 was supported - otherwise 3.7 installations would break. Since this is removing its support, we should remove the comment. |
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow - we really had to introduce lots of one-offs for 3.7 - this winds up being a nice cleanup - thanks.
Just a couple nits on tightening up the classifiers.
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @ptitzler.
This PR updates references to Python v3.7, which is no longer supported by Jupyterlab 4.0. To locate impacted files I've scanned the repository for
3.7
and37
.Need input on https://github.com/ptitzler/elyra/blob/rip-py7/pyproject.toml#L23 (What's supposed to be the new floor?)Signed-off-by: Patrick Titzler ptitzler@us.ibm.com
What changes were proposed in this pull request?
How was this pull request tested?
Developer's Certificate of Origin 1.1