Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure env stanza is an empty dict if no seed value is given to papermill engine #3103

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

kevin-bates
Copy link
Member

I'd like to reference our implementation of a Papermill Engine in the documentation for Gateway Provisioners to demonstrate how a user/developer can use Papermill against a Gateway server. When attempting to use the Papermill CLI to point at ElyraEngine, the notebook's execution would fail with the following stack (snippet):

  File "/opt/miniconda3/envs/elyra-dev/lib/python3.10/site-packages/jupyter_client/manager.py", line 397, in _async_start_kernel
    kernel_cmd, kw = await self._async_pre_start_kernel(**kw)
  File "/opt/miniconda3/envs/elyra-dev/lib/python3.10/site-packages/jupyter_client/manager.py", line 362, in _async_pre_start_kernel
    kw = await self.provisioner.pre_launch(**kw)
  File "/opt/miniconda3/envs/elyra-dev/lib/python3.10/site-packages/jupyter_client/provisioning/local_provisioner.py", line 200, in pre_launch
    return await super().pre_launch(cmd=kernel_cmd, **kwargs)
  File "/opt/miniconda3/envs/elyra-dev/lib/python3.10/site-packages/jupyter_client/provisioning/provisioner_base.py", line 157, in pre_launch
    env = kwargs.pop('env', os.environ).copy()
AttributeError: 'NoneType' object has no attribute 'copy'

because, by default, the env stanza would be None if using our engine directly.

This change enables the use of ElyraEngine as a referenceable example.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Kevin Bates <kbates4@gmail.com>
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akchinSTC akchinSTC merged commit 24b445e into elyra-ai:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants