Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov token to upload reports github action #3283

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

lresende
Copy link
Member

What changes were proposed in this pull request?

Add codecov token to upload reports github action

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Luciano Resende <lresende@apple.com>
@lresende lresende requested a review from caponetto January 23, 2025 01:30
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@408f4f8). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3283   +/-   ##
=======================================
  Coverage        ?   83.66%           
=======================================
  Files           ?      160           
  Lines           ?    19985           
  Branches        ?      514           
=======================================
  Hits            ?    16721           
  Misses          ?     3082           
  Partials        ?      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@caponetto caponetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we upload the reports for pytest, Cypress and jest, we'll also need the token here and here.

@lresende
Copy link
Member Author

@caponetto added the additional tokens... do we also need the reference from the codecov XML in all places?

Signed-off-by: Luciano Resende <lresende@apple.com>
@lresende lresende force-pushed the update-code-coverage-task branch from 83545be to 1393ecb Compare January 25, 2025 00:10
Copy link
Contributor

@caponetto caponetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thanks @lresende!

@lresende lresende merged commit bb80d2d into elyra-ai:main Jan 28, 2025
20 checks passed
@lresende lresende deleted the update-code-coverage-task branch January 28, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants