Switch to MSYS2 for installing Emacs on MS-Windows in CI (fix for #55) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes emacs-eldev#55. Should be reverted once new prebuilt Emacs MS-Windows binaries become available with a newer GnuTLS version.
|
@ikappaki: Hello. Now that Emacs 28.1 is out, can we revert to using |
Hi @doublep, yes we can revert, submitted #69 for it. (it is cs090218/setup-emacs-windows we revert to, not purcell/setup-emacs, I had made a mistake in the comments). thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
could you please consider fix for #55 whereby the Emacs MS-Windows precompiled binaries installed with
purcell/setup-emacs@masterGitHub action used in Eldev CI, ships with a GnuTLS version which is susceptible to a bug with expired issuer certificates.The solution proposed here is to install Emacs as an msys2 package. msys2 itself is already preinstalled on the GitHub Windows 2019 servers, we just utilize it to install the latest Emacs package and set up the global PATH to point to it with an additional GitHub action.
Once a new binary is available in
purcell/setup-emacs, we can switch back to that installer. The benefit ofpurcell/setup-emacsover msys2 is that you can specify which version to install, while with msys2 you can only download the latest available precompiled version (which can change without notice, i.e. going from 27.2 to 28.5 once that becomes available), i.e. no fine grain control which exact version/binary is being used.All test pass now on CI.
Thanks