vterm: bypass line wraps in the prompt line

[FrostyX]

When the command in the prompt line is so long that it wraps to multiple lines, movements such as h, l, ^, and $ IMHO behave unexpectedly. In normal terminal emulators outside of Emacs, a long prompt line contains only soft-wraps, i.e. being at the last character before a wrap and pressing <right> moves the cursor to the first character of the next line. This is also how vterm behaves without Evil. I am changing h and l to behave the same way.

While doing so, I am doing the same for ^ and $.

[FrostyX]

Just to easily illustrate behavior. When I press l without this patch, it does nothing. With this patch, it moves the cursor to the next line.

Similarly h goes to the previous line

This works in the visual mode as well.

[jojojames]

One last thing, can you add a flag (can default to true), to conditionally enable this.

Something like:

if flag:
bind l h $ ^ to -> new feature
else:
bind ^ (whatever other key needs to be deleted from thsi CL)

This cl is moving some lines to other parts so hard to tell what's missing/gained easily. (Not taking too close a look)

[FrostyX]

I agree, that sounds like a good idea. Please take a look.

[jojojames]

I think we should create 2 separate flags (one for ^ $ and one for h l) and then check the flags only in evil-collection-vterm-setup to conditionally bind the functions.

One use case I'm thinking (which is one I'd be using) is to only bind this for h & l movements but keep ^ and $ movements alone.

[FrostyX]

I think we should create 2 separate flags (one for ^ $ and one for h l)
One use case I'm thinking (which is one I'd be using) is to only bind this for h & l movements but keep ^ and $ movements alone.

It doesn't really make sense to me, separating the configuration into two options. In my case, I either want the prompt to behave like one long line or not :-). That being said, if you are interested in having this behavior just for h, k and not ^, $, maybe others will as well. So sure, no problem with me. Do you have any preference for the option names?

check the flags only in evil-collection-vterm-setup to conditionally bind the functions.

I am trying to find some other key bind that is done this way but not seeing any. Have you seen this approach somewhere else in evil-collection? I'd like to be consistent with it.

[FrostyX]

bump @jojojames

[jojojames]

evil-collection/modes/elpaca/evil-collection-elpaca.el

Line 105 in 5092f5e

(if evil-collection-elpaca-want-u-unmark

[FrostyX]

It won't be as easy as we thought. Or at least as I thought.

We would have to define two variants for every movement. I am proposing hj^$ in this PR but I forgot X, 0, operations till the end of the line like C, S, D, Y, jumps like t<char>, T<char>, or line operations like yy, dd, and whatever else. That would be too many vterm specific key binds. But more importantly too many key binds for this line-continuation feature. Imagine how much would the number of key binds blow up if we want to add some other feature with conditional keybinds. There must be a smarter way of doing this but I am struggling to find it.

I am playing with overriding something like evil-line-expand but without much success. It may be a dead end as well.

You have much more experience with Evil than me, do you have any idea @jojojames, please?

[jojojames]

Why are we removing this line?

[FrostyX]

I moved it from

  (evil-collection-define-key 'normal 'vterm-mode-map

to

  (evil-collection-define-key '(normal visual) 'vterm-mode-map

since I was creating this section, and it makes sense for d to work in visual mode as well.