-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch to enable lexical-binding and improve evil-delay #1685
Comments
Cool, sounds interesting. What URL do I git clone? |
Tom Dalziel [2022-10-01 09:50:14] wrote:
Cool, sounds interesting. What URL do I git clone?
git clone --single-branch -b scratch/evil \
git://git.sv.gnu.org/emacs/elpa.git
or
git remote add -t scratch/evil elpa-scratch \
git://git.sv.gnu.org/emacs/elpa.git
|
@monnier are you sure that branch is there/accessible? I get
|
@monnier are you sure that branch is there/accessible? I get
```
Cloning into 'elpa'...
warning: Could not find remote branch scratch/evil to clone.
fatal: Remote branch scratch/evil not found in upstream origin
```
Hmm... yeah, that was meant to say
git clone --single-branch -b scratch/evil \
git://git.sv.gnu.org/emacs/nongnu.git
or
git remote add -t scratch/evil elpa-scratch \
git://git.sv.gnu.org/emacs/nongnu.git
…-- Stefan "not proud"
|
Merged
I've brought this in as a branch on evil and opened a PR, linked. You'll see there are 3 failed tests. Please take a look when convenient - I'm not sure I'll have the time for a while. Cheers |
I've brought this in as a branch on evil and opened a PR, linked. You'll see
there are 3 failed tests.
Excellent, thanks
|
Sorry for the delay, at least it landed before Emacs 30 hit. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I pushed to the
scratch/evil
branch of nongnu.git a patch which enableslexical-binding
in all the files and replaces theevil-delay
function (which has to work via the awfuleval
) with anevil-with-delay
macro which lets the byte-compiler properly see and compile the code.The text was updated successfully, but these errors were encountered: