-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error with C-w T on Emacs < 28 #1811
Comments
@Tekki how about the fix in tomdl89@724a362 ? |
Looks good. Tested on 27 and 28. |
Is it not better to get an error that the command does not exist rather than that the keybinding does not exist? |
Possibly, but |
Only a meaningful message would be a real solution. At the moment, if we don't bind |
Issue type
Environment
Emacs version: 27.1
Operating System: Debian Bullseye
Evil version: 1.15.0
Evil installation type: Melpa
Graphical/Terminal: Yes
Reproduction steps
C-w T
Expected behavior
Buffer should be moved to a new tab, or nothing should happen.
Actual behavior
Error message: "Wrong type argument: commandp, tab-window-detach"
Further notes
tab-window-detach
only exists in Emacs >= 28. We should probably check for the existence of the function instead of the feature inevil-maps.el
:The text was updated successfully, but these errors were encountered: