Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use `ivy-configure' + display-transformer and undocumented ivy-update-candidates #33

Merged
merged 1 commit into from
May 18, 2021

Conversation

kiennq
Copy link
Member

@kiennq kiennq commented Apr 26, 2021

Based on #24 but remove the usage of ivy-update-candidates which is undocumented and not working with cons yet.
Also, return filtered result as string since the ivy-action is only accepting string for non alist collection.

@sebastiansturm
Copy link
Contributor

thanks! That seems to fix ivy actions on symbol candidates, and at least with my config there seems to be less flickering during candidate list updates, though I'm not sure if the latter is coincidental. I assume this is also supposed to fix the issues with prescient sorting (which so far I don't use, will have to check how the master branch behaves wrt current ivy versions)?

@kiennq
Copy link
Member Author

kiennq commented May 1, 2021

assume this is also supposed to fix the issues with prescient sorting (which so far I don't use, will have to check how the master branch behaves wrt current ivy versions)?

I'm not using prescient sorting so I'm not sure about this.
Can anyone that using prescient chime in?

@sebastiansturm
Copy link
Contributor

no point in letting this PR linger forever, as I didn't see anything wrong with it. Will try out your fork once more, then merge it

@sebastiansturm sebastiansturm merged commit bccd860 into emacs-lsp:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants