Implement semver comparison for rustic-doc dependencies
#48
Conversation
Velnbur
changed the title
rustic-doc dependencies
|
Thanks! Can you see why the tests are failing ? |
|
Hey, thanks for moving this PR here! :) |
There was a problem hiding this comment.
the changes described in my comments fix evaluation for me so that rustic-mode works.
(Unfortunately it turns out I actually can't test rustic-doc on my machine because I'm not using rustup to provide Rust. After this goes in, I'll have to open my own PR for that. :)
rustic-doc.el
Outdated
| (str-length (length splitted-str))) | ||
| (mapcar #'string-to-number | ||
| ;; take only first 3 elements or less | ||
| (subseq splitted-str 0 (min 3 str-length))))) |
There was a problem hiding this comment.
subseq
This isn't in scope on my system and makes defun evaluation fail. This should be seq-subseq, right?
There was a problem hiding this comment.
Interesting, by the time I made this PR, I had been using Doom Emacs, but my current configuration, that is made from scratch, doesn't have this function too. Maybe some of Doom Emacs dependencies added it to my environment. Added seq-subseq instead, tests seems working
There was a problem hiding this comment.
(as it happens, I'm using Doom currently, and this change was still required for it to work on my system)
Implement full comaparison for semver-like versions returned by pandoc and fd-find.
Velnbur
force-pushed
the
fix/rustic-doc-versions-check-fork
branch
from
3401daf
to
59353d1
Compare
|
Thank you for your comments! I'm beginer at writing Emacs packages code, so really appreciate your comments! Also, |
As a NixOS user, I have this kind of issues too. I planned modifing current behavior by setting path to |
I started a discussion about related issues here. It'll tag you as a reviewer when I start that work! That way you can at least follow along and we can learn together, even if you don't have time to work on it yourself. |
|
@therealpxc Since this PR is assigned to you, let me know when it's ready to merge. I don't use |
|
Merging this as another user has reported that this fixes the issue for them: #66 (comment) |
Implement full comaparison for semver-like versions returned by pandoc and fd-find.
Closes brotzeit/rustic#502