fix: don't eval function calls for suggestions (#1382)

embarklabs · Mar 5, 2019 · 73a0672 · 73a0672
1 parent 78201ce
commit 73a0672
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/packages/embark/src/lib/modules/console/suggestions.ts b/packages/embark/src/lib/modules/console/suggestions.ts
@@ -92,7 +92,10 @@ export default class Suggestions {
   }
 
   public getSuggestions(cmd: string, cb: (results: SuggestionsList) => any) {
+    // Don't bother returning suggestions for empty commands or for
+    // commands that already have `(` or `)` to avoid executing code
     if (cmd === "") { return cb([]); }
+    if (cmd.indexOf("(") !== -1 || cmd.indexOf(")") !== -1) { return cb([]); }
 
     const suggestions = this.suggestions;