build: use babel cli's --extensions consistently in all packages
#1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a package uses only `.js` then supply `--extensions ".js"`. If a package uses only `.ts` then supply `--extensions ".ts"`. If a package uses both, then supply `--extensions ".js,.ts"`. The reason for this is that adding/removing TS/JS support ought to occasion revising a package's `package.json` file and adjusting other scripts as well, e.g. for linting. With these changes, it won't work to simply start adding `.ts` files in a package's `src/` directory, which should prompt the developer to review `package.json` and make the appropriate changes, and/or other developers may realize changes need to be made during code review.
emizzle
approved these changes
May 3, 2019
michaelsbradleyjr
added a commit
that referenced
this pull request
May 3, 2019
This was referenced May 3, 2019
michaelsbradleyjr
added a commit
that referenced
this pull request
May 3, 2019
This was referenced May 3, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a package uses only
.jsthen supply--extensions ".js". If a package uses only.tsthen supply--extensions ".ts". If a package uses both, then supply--extensions ".js,.ts".The reason for this is that adding/removing TS/JS support ought to occasion revising a package's
package.jsonfile and adjusting other scripts as well, e.g. for linting. With these changes, it won't work to simply start adding.tsfiles in a package'ssrc/directory, which should prompt the developer to reviewpackage.jsonand make the appropriate changes, and/or other developers may realize changes need to be made during code review.