Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use babel cli's --extensions consistently in all packages #1575

Merged
merged 1 commit into from
May 3, 2019

Commits on May 2, 2019

  1. build: use babel cli's --extensions consistently in all packages

    If a package uses only `.js` then supply `--extensions ".js"`. If a package
    uses only `.ts` then supply `--extensions ".ts"`. If a package uses both, then
    supply `--extensions ".js,.ts"`.
    
    The reason for this is that adding/removing TS/JS support ought to occasion
    revising a package's `package.json` file and adjusting other scripts as well,
    e.g. for linting. With these changes, it won't work to simply start adding
    `.ts` files in a package's `src/` directory, which should prompt the developer
    to review `package.json` and make the appropriate changes, and/or other
    developers may realize changes need to be made during code review.
    michaelsbradleyjr committed May 2, 2019
    Configuration menu
    Copy the full SHA
    28d56b9 View commit details
    Browse the repository at this point in the history