Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chainId and/or networkName to the JSON Artifact #2220

Closed
kamescg opened this issue Jan 27, 2020 · 1 comment · Fixed by #2335
Closed

Add chainId and/or networkName to the JSON Artifact #2220

kamescg opened this issue Jan 27, 2020 · 1 comment · Fixed by #2335

Comments

@kamescg
Copy link

kamescg commented Jan 27, 2020

Feature Request

Using the embark new [dApp] --contracts-only boilerplate. I Only require embark to build and deploy my smart contracts.

The artifacts, after they are deployed, are migrated to an existing decentralized application frontend. That frontend auto-imports contract via the JSON file and initializes the contract by detecting what network the contract was deployed on.

From what I can tell the artifact does not include the chainId or networkName and thus my application is unable to detect what network the contract should connect with.

Summary

Can the chainId and/or networkName be added to the artifact.

Thank you 😄

@jrainville
Copy link
Collaborator

Sounds quite reasonable. I'll pass it on to the team.
Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants