This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
Define GenerixSx1272 and GenericSx1276 board types #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In long run, the BoardType enum should be dropped in favor of a struct-based approach and probably a Sealed implementation for chips as well, but at least add some generic board definitions to allow out-of tree implementations for sx1272 and sx1276-based boards.
|
Closed as there's better implementation in #37. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In long run, the BoardType enum should be dropped in favor of a struct-based approach and probably a Sealed implementation for chips as well, but at least add some generic board definitions to allow out-of tree implementations for sx1272 and sx1276-based boards.