Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of discrepancies for gte-Qweb model #1637

Conversation

AlexeyVatolin
Copy link
Contributor

#1600

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

@AlexeyVatolin AlexeyVatolin force-pushed the gte-qwen-corrent-implementation branch from 38357ca to 68369b4 Compare December 27, 2024 19:42
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time on this. The new results looks promising. Do we want to rerun this to update the results on the leaderboard?

@KennethEnevoldsen KennethEnevoldsen merged commit 2de61b1 into embeddings-benchmark:main Dec 29, 2024
10 checks passed
@AlexeyVatolin
Copy link
Contributor Author

@KennethEnevoldsen, I'm not sure if a rerun is required. The current results from MTEB are almost identical to the leaderboard. It is unlikely that the model will change its position in the leaderboard after the rerun. Recalculating the scores makes sense if we want the implementation in MTEB to match the leaderboard 100%

@KennethEnevoldsen
Copy link
Contributor

alright then I would just leave it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants