Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix output_folder for co2 evaluation #1642

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Fix output_folder for co2 evaluation #1642

merged 1 commit into from
Dec 30, 2024

Conversation

Muennighoff
Copy link
Contributor

lol surprised we had this bug; it literally errors out for me 😁

@Samoed
Copy link
Collaborator

Samoed commented Dec 30, 2024

Previously, I tried to remove the output_folder parameter and pass it through kwargs, since it’s only needed for retrieval. However, it seems that during refactoring, I accidentally removed it.

@Samoed Samoed merged commit 366b2ce into main Dec 30, 2024
10 checks passed
@Samoed Samoed deleted the Muennighoff-patch-1 branch December 30, 2024 06:57
@Muennighoff
Copy link
Contributor Author

No worries! Thanks for merging 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Muennighoff @Samoed