Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate a11yAuditIf #203

Merged
merged 4 commits into from
Aug 31, 2020
Merged

Deprecate a11yAuditIf #203

merged 4 commits into from
Aug 31, 2020

Conversation

scalvert
Copy link
Contributor

Adds a deprecation warning for a11yAuditIf and integrates that functionality into a11yAudit. The latter will become the primary primitive to invoke audits.

rwjblue
rwjblue reviewed Aug 28, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
addon-test-support/audit-if.ts Show resolved Hide resolved
addon-test-support/audit.ts Outdated Show resolved Hide resolved
@rwjblue rwjblue changed the title Deprecates a11yAuditIf in favor of a single API Deprecate a11yAuditIf Aug 31, 2020
@rwjblue rwjblue merged commit 853528a into ember-a11y:master Aug 31, 2020
@scalvert scalvert mentioned this pull request Sep 1, 2020
Closed
11 tasks
@fivetanley fivetanley mentioned this pull request Sep 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scalvert @rwjblue