-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ability to post violations via middleware #212
Conversation
7e64401
to
ab33aa6
Compare
Just as a general question, since I didn't see this directly referred to in the code - how does the host application determine whether they want to run tests w/reporter vs no reporter (i.e., conditionally)? For example, we may not need the reporter for CI/CD process or local execution, while requiring the reporter for a nightly job. Would we just wrap |
@drewlee - yes. I think we can configure that in the test-helper.js file via a custom query param. |
@rwjblue WDYT about us moving the parallel execution support ( |
a6de773
to
3501bde
Compare
3501bde
to
7ea81e0
Compare
serverMiddleware(startOptions) { | ||
setupMiddleware(startOptions.app, { | ||
root: this.project.root, | ||
}); | ||
}, | ||
|
||
testemMiddleware(app) { | ||
setupMiddleware(app, { | ||
root: this.project.root, | ||
}); | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The differences in these methods (from ember-cli's side) is very annoying 😭
Adds support for combining the custom reporter with custom middleware, which allows for serializing the results to JSON.
This will setup a custom reporter, which gathers the test module name, test name, and violations for each failed audit. Once the suite is done, these results are posted to the testem middleware, ultimately serializing the results to disc.
TODO:
setupMiddlewareReporter
setupMiddleware
test to use realAxeResults
setupMiddlewareReporter
in order to save the results.