Adjusting time of data gathering in middleware reporter #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewlee
reviewed
Jun 8, 2021
drewlee
approved these changes
Jun 8, 2021
rwjblue
reviewed
Jun 8, 2021
Co-authored-by: Andrew A Lee <andlee@linkedin.com>
…ember-a11y-testing into fix-metadata-timings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a subtle timing issue that occurs in the middleware reporter, whereby we can't guarantee that all test metadata is setup by the time it's accessed. The only way to ensure all metadata is setup for the test is by accessing it lazily, via
testDone.This will become particularly important when trying to gather additional data destined for the middleware report, such as the filepath work that's currently being implemented. We'd want to ensure we access this metadata inside
pushTestResult.