fix ember-try for >= 5.x releases #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `@ember/string` to `devDependencies` for ember-resolver and other dependencies - Update `ember-resolver` - Remove `ember-export-application-global` as we don't need it and it causes other build issues
fivetanley
force-pushed
the
canary-beta-fixes
branch
from
7c3f275 to
3f4329a
Compare
MelSumner
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ember/stringtodevDependenciesfor ember-resolver and other dependencies, as these dependencies now depend upon it as apeerDependencyinstead of a normaldependencyember-resolverember-export-application-globalas we don't need it and it causes other build issuesfixes #504