Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures context for current URL & route middleware reporting #514

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

drewlee
Copy link
Contributor

@drewlee drewlee commented Aug 23, 2023

Summary

In some circumstances, when using the middleware reporter, the a11y audit completes after test context has been torn down, resulting in test failures due to the thrown errors from using currentURL and currentRouteName. The fix ensures context exists before these two methods are called.

Testing Done

  • Local tests pass.
  • Manually validated tests are no longer failing from within the context of a host app.

@drewlee drewlee added the bug label Aug 23, 2023
@drewlee drewlee merged commit 73b2bef into master Aug 23, 2023
@drewlee drewlee deleted the drewlee/curr-url branch August 23, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant