[BREAKING] include hidden files in distFiles #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dot files are ignored from glob.sync , files like .htaccess would not get deployed since distFiles do not include hidden files. This commit configures glob.sync to include dot files. It should be relatively rare that this breaking change affects developer's apps, but we are considering it breaking because it could result in dot files becoming part of your deploy pipeline that were excluded in previous versions
lukemelia
added a commit
to ember-cli-deploy/ember-cli-deploy-lightning-pack
that referenced
this pull request
Sep 3, 2019
- Likelihood of change affecting your pipeline is low. See ember-cli-deploy/ember-cli-deploy-build#55 for details
|
Released as 2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be relatively rare that this breaking change affects developer's apps, but we are considering it breaking because it could result in dot files becoming part of your deploy pipeline that were excluded in previous versions