Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sourcemaps when publicUrl is used #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

astronomersiva
Copy link

I recently introduced a change in broccoli-uglify-sourcemap that allows specifying a publicUrl in sourcemaps. However, since the regex used only checks for sourceMappingUrl= followed by the name of the sourcemap itself, it will not get fingerprinted.

@Turbo87
Copy link
Member

Turbo87 commented Apr 4, 2019

why do you not use the prefix thing from the asset rewriter directly instead of the publicUrl option of uglify?

@astronomersiva
Copy link
Author

I hope you are talking about the prepend option. We cannot use it because it will add the URL to every single asset which is not what we want. publicUrl adds it only to sourcemaps.

@astronomersiva
Copy link
Author

A gentle reminder @Turbo87...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants