[FEATURE] Adds a buildError hook #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
/cc @rondale-sc |
|
@rwjblue Updated to assert the error thrown is the one received |
|
OOoh, fancy! Awesome stuff! Going to integrate with ember-cli-rails-addon asap. :)) |
| .then(this.processAddonBuildSteps.bind(this, 'postBuild')); | ||
| .then(this.processAddonBuildSteps.bind(this, 'postBuild')) | ||
| .catch(function(error) { | ||
| self.processAddonBuildSteps('buildError', error); |
There was a problem hiding this comment.
our convention is to use bind over self+closure like above
There was a problem hiding this comment.
We need to use the closure here to return the original error.
There was a problem hiding this comment.
this is not happening, the only closed over var is self.
`buildError` hook will be called on when an error occurs during the `preBuild` or `postBuild` hooks for addons, or when `builder#build` fails
|
Updated to use bind in for the closure scope, throws instead of |
rwjblue
added a commit
that referenced
this pull request
Dec 24, 2014
[FEATURE] Adds a buildError hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildErrorhook will be called on when an error occurs during thepreBuildorpostBuildhooks for addons, or whenbuilder#buildfails
/cc @rwjblue