Fail if parallel is not a numeric value

ember-cli · Nov 22, 2019 · d7bb163 · d7bb163
1 parent 221908f
commit d7bb163
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 1 deletion.
diff --git a/config/ember-try.js b/config/ember-try.js
@@ -8,6 +8,7 @@ const command = [
   '--split',
   '3',
   '--parallel',
+  '1',
   '--random',
   process.env.TRAVIS_PULL_REQUEST
 ].filter(Boolean).join(' ');

diff --git a/lib/commands/exam.js b/lib/commands/exam.js
@@ -34,7 +34,7 @@ module.exports = TestCommand.extend({
     },
     {
       name: 'parallel',
-      type: Number,
+      type: [Number, String],
       description: 'Runs your split tests on parallel child processes.'
     },
     {

diff --git a/lib/utils/tests-options-validator.js b/lib/utils/tests-options-validator.js
@@ -258,6 +258,15 @@ module.exports = class TestsOptionsValidator {
    * @return {boolean}
    */
   validateParallel() {
+    const parallelValue = parseInt(this.options.parallel, 10);
+
+    if (isNaN(parallelValue)) {
+      throw new SilentError(
+        `EmberExam: You must specify a Numeric value to 'parallel'. Value passed: ${this.options.parallel}`
+      );
+    }
+    this.options.parallel = parallelValue;
+
     if (typeof this.options.replayBrowser !== 'undefined') {
       throw new SilentError(
         'EmberExam: You must not use the `replay-browser` option with the `parallel` option.'

diff --git a/node-tests/unit/utils/tests-options-validator-test.js b/node-tests/unit/utils/tests-options-validator-test.js
@@ -162,6 +162,14 @@ describe('TestOptionsValidator', function() {
   });
 
   describe('shouldParallelize', function() {
+    it('should throw an error if `parallel` is not a numeric value', function() {
+      shouldThrow(
+        'Parallel',
+        { parallel: '--reporter' },
+        /EmberExam: You must specify a Numeric value to 'parallel'. Value passed: --reporter/
+      );
+    });
+
     it('should throw an error if `split` is not being used', function() {
       shouldThrow(
         'Parallel',