Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error when there are no matching tests with a given input by file-path and module-path #302

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

choheekim
Copy link
Collaborator

filter and module provided by ember-cli throws an error when there are no tests matched with the filter input saying No tests matched the filter. This pr is to throw an error when there are no matching tests with a given input by file-path and module-path as the same behavior as filter and module.

@choheekim choheekim force-pushed the file-path-filtering branch from ed5165b to 2565daf Compare June 19, 2019 00:25
Copy link
Collaborator

@step2yeung step2yeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @choheekim LGTM!

@choheekim choheekim closed this Jun 25, 2019
@choheekim choheekim reopened this Jun 25, 2019
@choheekim choheekim merged commit ca2a29c into ember-cli:master Jun 25, 2019
@choheekim choheekim deleted the file-path-filtering branch June 25, 2019 00:45
@choheekim
Copy link
Collaborator Author

Thanks @choheekim LGTM!

Merged 👍

@choheekim choheekim restored the file-path-filtering branch June 25, 2019 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants