Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to support ember-qunit@5 #652

Merged
merged 16 commits into from
Feb 17, 2021
Merged

Update to support ember-qunit@5 #652

merged 16 commits into from
Feb 17, 2021

Conversation

thoov
Copy link
Contributor

@thoov thoov commented Feb 16, 2021 •
edited by rwjblue
Loading

  • Migrates to using @embroider/test-setup
  • Adds test scenarios for ember-lts-3.24
  • Updates ember-qunit to 5.x series
  • Adds test scenario for ember-qunit@4
  • Guard all test imports of QUnit / Mocha related modules behind macroCondition + dependencySatisfies
  • Ensure mocha related test scenarios uninstall ember-qunit

Fixes #634

rwjblue
rwjblue reviewed Feb 17, 2021
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add another scenario that uses ember-qunit@4?

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
thoov and others added 5 commits February 16, 2021 16:17
@thoov
adding ember-qunit-4 test case
7d7cd6d
@thoov
adding ci test case for ember-qunit-4
44fb541
@thoov
fixing ember-qunit-4 test
2a57522
@thoov
handle different imports
0afb285
@rwjblue
Remove redundant setupTest invocation.
512ad87 
This resolves the error when using ember-destroyable-polyfill and
calling `setupContext` (from `@ember/test-helpers`) multiple times with
the same test context.
@rwjblue rwjblue force-pushed the embroider-test-setup branch from a91d51e to 512ad87 Compare February 17, 2021 03:08
rwjblue
rwjblue reviewed Feb 17, 2021
View reviewed changes
.github/workflows/ci.yml
- ember-lts-3.20
- ember-lts-3.16
- ember-lts-3.12
- ember-release
- ember-beta
- ember-canary
- ember-qunit-4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for adding this

@rwjblue rwjblue marked this pull request as ready for review February 17, 2021 03:15
@rwjblue rwjblue merged commit 7d99254 into ember-cli:master Feb 17, 2021
@rwjblue rwjblue changed the title Use @embroider/test-setup and get embroider passing Update to support ember-qunit@5 Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not find module qunit imported from (require)
2 participants
@thoov @rwjblue