Upgrade @embroider/* packages to 1.0.0
#840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
commented
Jan 21, 2022
| @@ -6,7 +6,7 @@ import { | |||
| } from '@embroider/macros'; | |||
|
|
|||
| if (macroCondition(dependencySatisfies('ember-qunit', '*'))) { | |||
| let { module, test } = importSync('qunit'); | |||
| let { module, test } = importSync('qunit').default; | |||
There was a problem hiding this comment.
I assume previous versions of @embroider/macro happily "swallowed" qunit not being an ES module but now we need to be explicit.
I assume this has changed in embroider-build/embroider#1076 ad should be way to move forward in such scenarios.
@ef4 would appreciate you can confirm
There was a problem hiding this comment.
I think you're correct. It was a bug that we allowed this to work before with .default.
SergeAstapov
force-pushed
the
bump-embroider-deps
branch
from
edbc63d
to
bba8be2
Compare
rwjblue
approved these changes
Jan 25, 2022
This was referenced Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #838 and #822 and makes CI pass.
This should help ecosystem migrate to v1 of
@embroider/*packages.