Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sadness with ember-cli-fastboot #371

Closed
rwjblue opened this issue Oct 23, 2019 · 0 comments · Fixed by #372
Closed

Sadness with ember-cli-fastboot #371

rwjblue opened this issue Oct 23, 2019 · 0 comments · Fixed by #372
Assignees

Comments

@rwjblue
Copy link
Member

rwjblue commented Oct 23, 2019

Haven't had much time to dig into this yet, but I just spun up a new app with ember-cli@3.14.0-beta.1 and get an error when I add ember-cli-fastboot.

Steps to reproduce:

npx ember-cli@3.14.0-beta.1 new foo --yarn
cd foo
yarn add -D ember-cli-fastboot
ember serve --port 0

Then visit / in the app. I see:

Error: You must provide a hostWhitelist to retrieve the host
    at FastBootRequest.host (/Users/rjackson/src/rwjblue/test-disabling-loading-routes/node_modules/fastboot/src/fastboot-request.js:22:13)
    at Class._host (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/addon-tree-output/ember-cli-fastboot/services/fastboot.js:25:1)
    at Class.<anonymous> (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/addon-tree-output/ember-cli-fastboot/services/fastboot.js:30:1)
    at untrack (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/@ember/-internals/metal/index.js:3324:1)
    at untrack (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/@ember/-internals/metal/index.js:1247:1)
    at ComputedProperty.get (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/@ember/-internals/metal/index.js:3323:1)
    at Class.CPGETTER_FUNCTION [as host] (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/@ember/-internals/metal/index.js:1044:1)
    at getPossibleMandatoryProxyValue (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/@ember/-internals/metal/index.js:1269:1)
    at get (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/@ember/-internals/metal/index.js:1342:1)
    at Class.get (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/@ember/-internals/runtime/lib/mixins/observable.js:116:1)
    at Object.patchFetchForRelativeURLs [as initialize] (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/test-disabling-loading-routes/instance-initializers/setup-fetch.js:19:1)
    at _runInitializer (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/@ember/engine/index.js:156:1)
    at Vertices.each (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/dag-map.js:231:1)
    at Vertices.walk (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/dag-map.js:145:1)
    at DAG.each (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/dag-map.js:75:1)
    at DAG.topsort (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/dag-map.js:83:1)
    at Class._runInitializer (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/@ember/engine/index.js:171:1)
    at Class.runInstanceInitializers (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/@ember/engine/index.js:154:1)
    at Class._bootSync (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/@ember/application/instance.js:111:1)
    at _bootPromise._runtime.RSVP.Promise.resolve (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/@ember/engine/instance.js:85:1)
    at initializePromise (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/rsvp.js:520:1)
    at new Promise (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/rsvp.js:1021:1)
    at Class.boot (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/@ember/engine/instance.js:85:1)
    at buildAppInstance.then.appInstance (/Users/rjackson/src/rwjblue/test-disabling-loading-routes/node_modules/fastboot/src/ember-app.js:292:25)
    at invokeCallback (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/rsvp.js:493:1)
    at publish (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/rsvp.js:476:1)
    at _runloop.backburner.schedule (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/ember-testing/lib/ext/rsvp.js:19:1)
    at invokeWithOnError (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/backburner.js:347:1)
    at Queue.flush (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/backburner.js:229:1)
    at DeferredActionQueues.flush (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/backburner.js:426:1)
    at Backburner._end (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/backburner.js:960:1)
    at Backburner._boundAutorunEnd (/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/broccoli-130653rRm3Dk7C9Vf/out-261-broccoli_merge_trees/assets/backburner.js:629:1)
    at process._tickCallback (internal/process/next_tick.js:68:7)

NOTE there is no actual attempt to use fetch at all in this setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants