Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throwing w/ fresh ember-cli-fastboot serve #372

Merged
merged 2 commits into from
Nov 3, 2019
Merged

fix: throwing w/ fresh ember-cli-fastboot serve #372

merged 2 commits into from
Nov 3, 2019

Conversation

xg-wang
Copy link
Member

@xg-wang xg-wang commented Oct 25, 2019

ember-cli-fastboot requires configuring host whitelist before accessing
host from request. In ember-fetch, the error should be lazily thrown.

fix: #371 cc @rwjblue @pzuraq

@xg-wang
fix: throwing w/ fresh ember-cli-fastboot serve
4292dcb 
ember-cli-fastboot requires configuring host whitelist before accessing
host from request. In ember-fetch, the error should be lazily thrown.
rwjblue
rwjblue reviewed Oct 25, 2019
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I don't really like having to try/catch here. Can we pass request in instead (so that we can only try to touch get(request, 'host') when needed)?

@xg-wang
Copy link
Member Author

xg-wang commented Oct 25, 2019

@rwjblue Will there be any memory leak concern for keeping the request? https://github.com/ember-fastboot/ember-cli-fastboot/blob/v2.2.1/addon/services/fastboot.js#L24

@rwjblue
Copy link
Member

rwjblue commented Oct 25, 2019

No, I don't think so.

@xg-wang
Copy link
Member Author

xg-wang commented Oct 26, 2019 •
edited
Loading

Seems some strange floating dep caused ember test to fail. fixed

@xg-wang xg-wang requested a review from rwjblue October 26, 2019 06:16
@xg-wang xg-wang merged commit b5a867e into ember-cli:master Nov 3, 2019
@xg-wang xg-wang deleted the host branch November 3, 2019 22:33
@xg-wang xg-wang added the bug label Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue Awaiting requested review from rwjblue

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sadness with ember-cli-fastboot
2 participants
@xg-wang @rwjblue