-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fetch response and error utils #303
Add fetch response and error utils #303
Conversation
I think these are helpful to make people using fetch api easier, but there're some differences when migrating from Ajax to Fetch, I did a quick check on our polyfills (https://github.com/mo/abortcontroller-polyfill and https://github.com/github/fetch) my comments about response type are also true. Can you make the code changes and explicitly call out in Readme doc? |
Thanks for the review. It was very helpful. I learned a lot reading the fetch and related specs I've added a section to the readme too |
Transitioning from
ember-ajax
toember-fetch
and noticed there weren't any error detection helpersThis PR adds similar helpers, mostly a copy/paste. Main motivation is to aid in transitioning between the two.
I looked through npm briefly to see if something similar already existed, but couldn't find anything. If we want to move forward with this, I can add some documentation to the readme.